Update grad_op_builder after refactoring framework proto. #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reyoung
reviewed
Aug 9, 2017
| std::string dst_name = is_grad ? GradVarName(src_name) : src_name; | ||
| for (auto& var_name : src_inout.at(src_name)) { | ||
| std::string s = is_grad ? GradVarName(var_name) | ||
| : (arg.no_gradient() ? kEmptyVarName : var_name); |
There was a problem hiding this comment.
If arg.no_gradient && !is_grad, just continue the outter loop.
kEmptyVarName is not needed. If map does not have that key, it means that input is empty.
reyoung
reviewed
Aug 9, 2017
| for (auto& var_name : src_inout.at(src_name)) { | ||
| std::string s = is_grad ? GradVarName(var_name) | ||
| : (arg.no_gradient() ? kEmptyVarName : var_name); | ||
| dst_inout[dst_name].emplace_back(s); |
There was a problem hiding this comment.
It seems that the vector should be reserve before?
|
I merged it so to accelerate the overall process. Let's fix @reyoung 's comments in following PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
input_formatandoutput_formatcan be removed.grad_op_builder_testoperator_test