Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor fixes #23

Merged
merged 5 commits into from
Dec 14, 2016
Merged

minor fixes #23

merged 5 commits into from
Dec 14, 2016

Conversation

helinwang
Copy link
Collaborator

please refer to each commit message for detail.

@wangkuiyi wangkuiyi self-requested a review December 14, 2016 20:59
@wangkuiyi
Copy link
Owner

LGTM

@@ -34,6 +34,7 @@ git clone --depth 1 {{.CloneURL}} repo
cd repo
git fetch origin {{.Ref}}
git checkout -qf {{.Head}}
git submodule update --init
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd thought that I'd have to run git submodule update within that empty mount directory. So it can be run in the root directory of the source code tree!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it can be run on the root dir, seems like it sync every submodule inside code base.

@helinwang helinwang merged commit e7d8d7c into wangkuiyi:develop Dec 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants