Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

version 4.1: add bad seed checkers #123

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

version 4.1: add bad seed checkers #123

wants to merge 1 commit into from

Conversation

rurban
Copy link
Contributor

@rurban rurban commented Nov 3, 2022

in C++ fixup the seed, in C just check

version 4.1: add bad seed checkers
c080982 
in C++ fixup the seed, in C just check
tansy
tansy reviewed Nov 8, 2022
View reviewed changes
Copy link
Contributor

@tansy tansy left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variable `wyhash32low_badseeds' should rather be called `wyhash_low32_badseeds' or something similar as `wyhash32...' suggests it is a wyhash32 'internal'.

Btw. How do you find these bad seeds?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tansy tansy tansy left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rurban @tansy