Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot end/close the stream #4

Closed
roccomuso opened this issue Jun 10, 2017 · 3 comments
Closed

Cannot end/close the stream #4

roccomuso opened this issue Jun 10, 2017 · 3 comments

Comments

@roccomuso
Copy link
Contributor

I've not being able to pipe something into a buffer using concat-stream. I guess because there's not a clear way to gracefully end the stream. Neither with destroy.

Any hints?
roccomuso added a commit to roccomuso/node-datagram-stream that referenced this issue Jun 10, 2017
@roccomuso
gracefully close the stream, address wankdanker#4
6654246
@roccomuso
Copy link
Contributor Author

Or you can listen for the close event and emit end on the socket.

@wankdanker
Copy link
Owner

If your patch which has been merged fixes this issue, please close this issue. Thank you!

@roccomuso
Copy link
Contributor Author

@wankdanker Yes. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wankdanker @roccomuso