Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates:1) Allow Picker values to be passed in 2) Ensure picker and table view cell remain in sync 3) iPad issue on iOS 8.0 #12

Merged
merged 4 commits into from Apr 23, 2015
Merged

Updates:1) Allow Picker values to be passed in 2) Ensure picker and table view cell remain in sync 3) iPad issue on iOS 8.0 #12

merged 4 commits into from Apr 23, 2015

Conversation

ctd-mh3
Copy link
Contributor

@ctd-mh3 ctd-mh3 commented Jul 31, 2013

Changes to:

  1. Allow UIPickerView values in SimplePickerInputTableViewCell to be passed to class.
  2. Noticed master had an issue when the the SimplePickerInputTableViewCell was closed with the UIPickerView was in motion. SimplePickerInputTableViewCell would keep state of last value that iOS considered selected while the picker continued to another value off screen. When the picker was reopened, the SimplePickerInputTableViewCell and Picker's current value were not aligned.

Looks like a couple of my Xcode setting files were incorrectly added to my commit.

@ctd-mh3
Updated to 1) Allow Picker values to be passed into class and 2) Ensu…
9babaf9 
…re picker and table view cell remain in sync.
@ctd-mh3
Change to prevent crash on iOS7
796cc65 
Called to prevent crash in iOS7 due to parent of each tabel cell not
being a UITableView as was assumed by the code.  in iOS7 the parent is
a UITableViewWrapperView.  Code would crash when attempting to use
indexPathForCell method.
@ctd-mh3
Possible fix for iOS iPad issue.
31dd927
@ctd-mh3
Merge of master.
832295f
@ctd-mh3
Copy link
Contributor Author

ctd-mh3 commented Sep 24, 2014

Instead of letting me create new pull request for iOS 8.0 iPad issue, GitHub (or user error) forced me to add those changed to this pull request.

@ctd-mh3 ctd-mh3 changed the title Updates:1) Allow Picker values to be passed in 2) Ensure picker and table view cell remain in sync Updates:1) Allow Picker values to be passed in 2) Ensure picker and table view cell remain in sync 3) iPad issue on iOS 8.0 Sep 24, 2014
wannabegeek added a commit that referenced this pull request Apr 23, 2015
@wannabegeek
Merge pull request #12 from ctd-mh3/master
2f7e9ef 
Updates:1) Allow Picker values to be passed in 2) Ensure picker and table view cell remain in sync 3) iPad issue on iOS 8.0
@wannabegeek wannabegeek merged commit 2f7e9ef into wannabegeek:master Apr 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ctd-mh3 @daviddelmonte @wannabegeek