Note bad limit on offsets for find().

wanproxy · Jun 26, 2015 · 5b7d867 · 5b7d867
1 parent 6cf2245
commit 5b7d867
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/common/buffer.h b/common/buffer.h
@@ -1080,6 +1080,10 @@ class Buffer {
 	 * Finds the first occurance of character ch in this Buffer's data and
 	 * sets offsetp to the offset it was found at.  If a limit is given, at
 	 * most that many characters will be searched.
+	 *
+	 * XXX
+	 * We need to convert the offset here to a size_t, since we might have
+	 * a lot of data in a Buffer these days.
 	 */
 	bool find(uint8_t ch, unsigned *offsetp, size_t limit = 0) const
 	{