Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sddpy violates license #2

Closed
odow opened this issue Jun 12, 2021 · 2 comments
Closed

sddpy violates license #2

odow opened this issue Jun 12, 2021 · 2 comments

Comments

@odow
Copy link

odow commented Jun 12, 2021

SDDP.jl is licensed under MPL2.0: https://github.com/odow/SDDP.jl/blob/v0.0.2/LICENSE.md

If you copy it directly

sddpy/sddp/state.py

Lines 10 to 12 in cb13103

# TODO SDDP.jl号称是数值问题,
# https://github.com/odow/SDDP.jl/issues/6#issuecomment-343022931
for st, v in zip(sp.states, s.state): # type:State,float

including the file structure

image

image

and the code is a direct translation from Python to Julia:

sddpy
image
SDDP.jl
image
(including TODOs to make it more like SDDP.jl) then it is a derivative work.

Therefore, you need to acknowledge where it came from (including keeping the copyright headers in each file) and release your code under the same license.

Please do one of the following:

  • delete this repository
  • re-instate the copyright headers and change the license to MPL2
@wanqiuchansheng
Copy link
Owner

I'm sorry for the license violation. According to @odow 's advice, the copyright headers has been added to all the files and the license to has been changed to MPL2. Acknowledge and reference of the code have also been added.

@odow
Copy link
Author

odow commented Jun 15, 2021

Thanks. Since you wrote the python code, you can add your name to the copyright headers. You just need to retain the original.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants