Refactor/signin and signup #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
아직 카드는 진행하지 않았습니다. 카드에 있는 로직 전부를 수정해야하기 때문에 일단 카드쪽의 validation 은 주석했습니다.
|
✔️ Deploy Preview for this-is-jaranda-develop ready! 🔨 Explore the source changes: 1e6c436 🔍 Inspect the deploy log: https://app.netlify.com/sites/this-is-jaranda-develop/deploys/610ffe6a1786b80007d8339a 😎 Browse the preview: https://deploy-preview-144--this-is-jaranda-develop.netlify.app/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
signup과 signin 리팩토링 진행했습니다.
signin은 useCallback만 지워서 신경쓰지 않으셔도 될거같습니다.
signup 코드 중복 제거, validation 과정 등... 많은 부분 리팩토링했습니다.