Specify the latest version with caret #117
Merged
+33
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I checked with this (released as {
...
"frolint": "0.6.9-alpha.0",
...
"resolutions": {
"eslint": "6.0.1"
}
} |
yamadayuki
changed the title
|
@KentoMoriwaki Please review this later. |
yamadayuki
added
bug
KentoMoriwaki
approved these changes
Jul 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY & WHAT
#115
frolintintroduced some bugs with upgrading ESLint to v6.x (this commit is reverted with my PR).Hypothesis: The latest ESLint (
eslint@6.x) has some removed private APIs. And then some ESLint community packages have depended on those APIs. We upgrade some plugin packages but the users faced the errors.So I decided to specify the latest packages with supporting v6.x