Split eslint config using @typescipt-eslint/parser or not #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY
The users (who aren't using TypeScript) intend to use
eslint-config-wantedly
but theeslint-config-wantedly
requirestypescript
as a dependency. It is not proper for the users only checking the quality of code.WHAT
I'm going to split the ESLint config into the two configs each are using
babel-eslint
and@typescript-eslint/parser
. So we provide two configseslint-config-wantedly
andeslint-config-wantedly-typescript
.If the user can afford to use TypeScript, he/she should use
eslint-config-wantedly-typescript
.