Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix space before function paren option #412

Merged

Conversation

yamadayuki
Copy link
Collaborator

WHY & WHAT

Conflicting the format in ESLint space-before-function-paren rule and Prettier. We should add a space before the parentheses if the function is anonymous function.

// correct
const foo = function () {};

// incorrect
const bar = function() {};

@yamadayuki yamadayuki added the bug Something isn't working label Apr 7, 2020
@yamadayuki yamadayuki merged commit 82e7d83 into master Apr 7, 2020
@yamadayuki yamadayuki deleted the yamadayuki/fix-space-before-function-paren-option branch April 7, 2020 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant