-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce eslint-plugin-react-hooks rules #66
Conversation
@chloe463 plz review on it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed!
@@ -6,7 +6,7 @@ module.exports = { | |||
extends: [...extendOptions, "plugin:react/recommended"], | |||
parser, | |||
parserOptions, | |||
plugins: [...plugins, "react"], | |||
plugins: [...plugins, "react", "react-hooks"], | |||
rules: { | |||
...rules, | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No rules of react-hooks are added?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch! I added the rules.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
I intend to publish the |
To close #59
Introduce
eslint-plugin-react-hooks
.c.f. https://reactjs.org/docs/hooks-rules.html#eslint-plugin