Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce eslint-plugin-react-hooks rules #66

Merged
merged 5 commits into from
May 13, 2019
Merged

Conversation

yamadayuki
Copy link
Collaborator

To close #59

Introduce eslint-plugin-react-hooks.
c.f. https://reactjs.org/docs/hooks-rules.html#eslint-plugin

@yamadayuki yamadayuki requested a review from chloe463 May 13, 2019 05:28
@yamadayuki
Copy link
Collaborator Author

@chloe463 plz review on it?

Copy link
Contributor

@chloe463 chloe463 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed!

@@ -6,7 +6,7 @@ module.exports = {
extends: [...extendOptions, "plugin:react/recommended"],
parser,
parserOptions,
plugins: [...plugins, "react"],
plugins: [...plugins, "react", "react-hooks"],
rules: {
...rules,

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No rules of react-hooks are added?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch! I added the rules.

Copy link
Contributor

@chloe463 chloe463 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@yamadayuki yamadayuki merged commit 2c93160 into master May 13, 2019
@yamadayuki yamadayuki deleted the yamadayuki/hooks branch May 13, 2019 05:53
@yamadayuki
Copy link
Collaborator Author

I intend to publish the frolint@0.5.2 soon.

@yamadayuki yamadayuki added the enhancement New feature or request label Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rules for react hooks
2 participants