Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use eqeqeq rule smart option #729

Merged
merged 2 commits into from
Dec 29, 2020
Merged

Use eqeqeq rule smart option #729

merged 2 commits into from
Dec 29, 2020

Conversation

yamadayuki
Copy link
Collaborator

Why & What

Now our eqeqeq rule is set as "error". But the code below will be pointed out with an error.

a == null // check the a is not null or undefined

We should enable the smart option for eqeqeq rule.

@github-actions github-actions bot added eslint-config-wantedly-typescript https://www.npmjs.com/package/eslint-config-wantedly-typescript eslint-config-wantedly https://www.npmjs.com/package/eslint-config-wantedly repo Root directory of this project labels Dec 29, 2020
@yamadayuki yamadayuki added the enhancement New feature or request label Dec 29, 2020
@yamadayuki
Copy link
Collaborator Author

cc @izumin5210

@yamadayuki yamadayuki merged commit fe7842a into master Dec 29, 2020
@yamadayuki yamadayuki deleted the yamadayuki/eqeqeq-smart branch December 29, 2020 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request eslint-config-wantedly https://www.npmjs.com/package/eslint-config-wantedly eslint-config-wantedly-typescript https://www.npmjs.com/package/eslint-config-wantedly-typescript repo Root directory of this project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@yamadayuki