Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax peerDependencies to typescript #734

Merged
merged 1 commit into from
Jan 4, 2021

Conversation

qnighy
Copy link
Contributor

@qnighy qnighy commented Jan 4, 2021

Why

We currently specify "typescript": "^3.8.3", which obviously led to false positives in our repos.

What

Specified >=3.3.1 <4.2.0 from https://github.com/typescript-eslint/typescript-eslint/tree/v4.11.1#supported-typescript-version .

@github-actions github-actions bot added eslint-config-wantedly-typescript https://www.npmjs.com/package/eslint-config-wantedly-typescript repo Root directory of this project labels Jan 4, 2021
@qnighy qnighy merged commit 6d7aec6 into master Jan 4, 2021
@qnighy qnighy deleted the qnighy/relax-typescript-peer-dep branch January 4, 2021 08:41
@yamadayuki yamadayuki added the bug Something isn't working label Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working eslint-config-wantedly-typescript https://www.npmjs.com/package/eslint-config-wantedly-typescript repo Root directory of this project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants