Update supported typescript version #943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
eslint-config-wantedly-typescript
To follow typescript-eslint's compatibility, after latest update in b2bcf66 Reference info: https://github.com/typescript-eslint/typescript-eslint/tree/v4.31.1#supported-typescript-version
prsdta
force-pushed
the
prsdta/update-typescript
branch
from
73575e4
to
0a4319b
Compare
prsdta
force-pushed
the
prsdta/update-typescript
branch
from
0a4319b
to
43f4f0a
Compare
prsdta
changed the title
qnighy
reviewed
Sep 22, 2021
yarn.lock
Outdated
Comment on lines
1680
to
1692
| "@typescript-eslint/experimental-utils@4.31.1": | ||
| version "4.31.1" | ||
| resolved "https://registry.yarnpkg.com/@typescript-eslint/experimental-utils/-/experimental-utils-4.31.1.tgz#0c900f832f270b88e13e51753647b02d08371ce5" | ||
| integrity sha512-NtoPsqmcSsWty0mcL5nTZXMf7Ei0Xr2MT8jWjXMVgRK0/1qeQ2jZzLFUh4QtyJ4+/lPUyMw5cSfeeME+Zrtp9Q== | ||
| dependencies: | ||
| "@types/json-schema" "^7.0.7" | ||
| "@typescript-eslint/scope-manager" "4.31.1" | ||
| "@typescript-eslint/types" "4.31.1" | ||
| "@typescript-eslint/typescript-estree" "4.31.1" | ||
| eslint-scope "^5.1.1" | ||
| eslint-utils "^3.0.0" | ||
|
|
||
| "@typescript-eslint/experimental-utils@^4.0.1": |
Typescript's stdlib only has the Error type from the browser, when Node.js actually uses an Error type with more properties. To avoid type errors, we use a type assertion inspired from https://dev.to/jdbar/the-problem-with-handling-node-js-errors-in-typescript-and-the-workaround-m64 Note: had to add a `globals` comment, since Eslint's `no-undef` rule does not handle the Noje.js global types.
prsdta
force-pushed
the
prsdta/update-typescript
branch
from
43f4f0a
to
dcd6ba2
Compare
|
Did a bit too much thinking for nothing on this one, it should be much simpler like this. |
qnighy
approved these changes
Sep 22, 2021
prsdta
force-pushed
the
prsdta/update-typescript
branch
from
dcd6ba2
to
fac1f96
Compare
|
Argh, not very used to this deduplicating schenanigans yet. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
We want to be able to use frolint with more recent versions of TS.
ref #876
To follow typescript-eslint's compatibility, after latest update in b2bcf66
Reference info:
https://github.com/typescript-eslint/typescript-eslint/tree/v4.31.1#supported-typescript-version
What
Update
typescript-eslintto the latest version. Update thetypescriptdependency to the link above.Also fixed a few type errors in the code caused by the update.