Set the ignorePath for prettier #952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prettier's node API does not read a `.prettierignore` file by default, which causes frolint to ignore that file. By simply adding a path to a `.prettierignore` file at the root of a project, prettier should be able to read it.
github-actions
bot
added
frolint
prsdta
force-pushed
the
prsdta/fix-prettier-ignore
branch
from
cb99e94
to
735db10
Compare
Use a temporary file to test the whole behavior of the prettier util, as a kind of an integration test.
prsdta
force-pushed
the
prsdta/fix-prettier-ignore
branch
from
735db10
to
920e2b3
Compare
prsdta
changed the title
prsdta
commented
Sep 24, 2021
| } ;`; | ||
|
|
||
| function createTestFile() { | ||
| (writeFileSync || writeFile)(testFilename, baseContent); |
There was a problem hiding this comment.
Had to use different APIs for different Node.js version. writeFileSync is not available in v12
tkeiyama
approved these changes
Sep 24, 2021
|
@tkeiyama Thanks 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
#949
What
By simply adding a path to a
.prettierignorefile at the root of a project, prettier should be able to read it.TODO