Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new spring4shell module to detect Spring4Shell #275

Closed
wants to merge 1 commit into from

Conversation

bretfourbe
Copy link
Collaborator

New module to detect Spring4Shell
image

@codecov-commenter
Copy link

codecov-commenter commented Mar 31, 2022

Codecov Report

Merging #275 (0f2f881) into master (0a886b3) will decrease coverage by 0.24%.
The diff coverage is 40.90%.

@@            Coverage Diff             @@
##           master     #275      +/-   ##
==========================================
- Coverage   73.74%   73.49%   -0.25%     
==========================================
  Files          85       87       +2     
  Lines        8637     8703      +66     
==========================================
+ Hits         6369     6396      +27     
- Misses       2268     2307      +39     
Impacted Files Coverage Δ
wapitiCore/attack/attack.py 91.85% <ø> (ø)
wapitiCore/attack/mod_spring4shell.py 32.75% <32.75%> (ø)
wapitiCore/definitions/spring.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a886b3...0f2f881. Read the comment docs.

logging.info(spring4shell_file_request)

# need to wait again and then we can check if file was created
await asyncio.sleep(10)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oulah :)

Si je comprends bien, ça fait que chaque tentative de requête génère une attente fixe de 10s ?

Si oui, ça fait cette tentative sur toutes les pages de l'appli ciblée ? Ou juste la racine ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

partout oui... si le payload fonctionne, il y a plusieurs secondes à attendre avant que le fichier soit accessible.. mais si ça fonctionne une fois on termine le module

@bretfourbe bretfourbe force-pushed the spring branch 2 times, most recently from 0f2f881 to e38067c Compare March 31, 2022 22:50
logging.info(spring4shell_file_request)

# need to wait again and then we can check if file was created
await asyncio.sleep(10)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A voir avec @fwininger

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

J'ai regardé et apparemment les autres scripts d'attaque mettent aussi un timer à genre 12 secondes :(.

)

# need to wait here and make a first request
await asyncio.sleep(10)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A voir avec @fwininger

@bretfourbe bretfourbe changed the title Add new spring module to detect Spring4Shell Add new spring4shell module to detect Spring4Shell Apr 1, 2022
@tarraschk
Copy link
Member

@bretfourbe : il faudra refactorer le tout pour passer à ton approche non intrusive, via des paramètres en Query Parameters

@tarraschk tarraschk marked this pull request as draft May 9, 2022 13:14
@tarraschk
Copy link
Member

@its0x08 I think the PR is "dangerous" as is based on the 10s delay imposed :)

Let's wait for refactoring to review it again?

@its0x08
Copy link

its0x08 commented May 9, 2022

Ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants