New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new spring4shell module to detect Spring4Shell #275
Conversation
Codecov Report
@@ Coverage Diff @@
## master #275 +/- ##
==========================================
- Coverage 73.74% 73.49% -0.25%
==========================================
Files 85 87 +2
Lines 8637 8703 +66
==========================================
+ Hits 6369 6396 +27
- Misses 2268 2307 +39
Continue to review full report at Codecov.
|
wapitiCore/attack/mod_spring.py
Outdated
logging.info(spring4shell_file_request) | ||
|
||
# need to wait again and then we can check if file was created | ||
await asyncio.sleep(10) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oulah :)
Si je comprends bien, ça fait que chaque tentative de requête génère une attente fixe de 10s ?
Si oui, ça fait cette tentative sur toutes les pages de l'appli ciblée ? Ou juste la racine ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
partout oui... si le payload fonctionne, il y a plusieurs secondes à attendre avant que le fichier soit accessible.. mais si ça fonctionne une fois on termine le module
0f2f881
to
e38067c
Compare
logging.info(spring4shell_file_request) | ||
|
||
# need to wait again and then we can check if file was created | ||
await asyncio.sleep(10) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A voir avec @fwininger
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
J'ai regardé et apparemment les autres scripts d'attaque mettent aussi un timer à genre 12 secondes :(.
) | ||
|
||
# need to wait here and make a first request | ||
await asyncio.sleep(10) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A voir avec @fwininger
@bretfourbe : il faudra refactorer le tout pour passer à ton approche non intrusive, via des paramètres en Query Parameters |
@its0x08 I think the PR is "dangerous" as is based on the 10s delay imposed :) Let's wait for refactoring to review it again? |
Ok |
New module to detect Spring4Shell