New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the types #89

Merged

wapmorgan merged 1 commit into wapmorgan:master from b1rdex:fix-the-types

Aug 5, 2020

Contributor

b1rdex commented Jul 21, 2020 •

edited

Loading

This PR:

fixes lots of wrong/missing PHPDoc types
adds PHP 7.4 to test matrix
adds PHPStan CI pipeline to do a static code analysis
adds a small portion of SCA-specific type hints (like array<string, string> to show the key type or array<\morphos\Cases::*> to reference interface constants) to further improve code quality
fixes GeographicalNamesInflection::getCase() expects int, string given. #88


          Fix the types

58c6b5e

b1rdex force-pushed the fix-the-types branch from fc74950 to 58c6b5e Compare

August 4, 2020 01:39

wapmorgan merged commit ba7f498 into wapmorgan:master

b1rdex deleted the fix-the-types branch

August 6, 2020 00:56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment