fix: writtebuffer not support sign integer

warcraft-iii · Aug 23, 2021 · 126cb86 · 126cb86
1 parent 255dace
commit 126cb86
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/src/lua/core/object.lua b/src/lua/core/object.lua
@@ -194,6 +194,9 @@ function createDefinition(defType, id, superId)
     if type(id) == 'number' then
         id = string.pack('>I', id)
     end
+    if type(superId) == 'number' then
+        superId = string.pack('>I', superId)
+    end
 
     if CREATED_DEFINITIONS[id] then
         error(string.format('%s already exists', id), 2)

diff --git a/src/lua/core/writebuffer.lua b/src/lua/core/writebuffer.lua
@@ -34,11 +34,11 @@ function WriteBuffer:addChar(value)
 end
 
 function WriteBuffer:addInt(value)
-    self:add(string.pack('I4<', value))
+    self:add(string.pack('i4<', value))
 end
 
 function WriteBuffer:addShort(value)
-    self:add(string.pack('I2<', value))
+    self:add(string.pack('i2<', value))
 end
 
 function WriteBuffer:addFloat(value)