Rails 5 Support #24
Merged
Rails 5 Support #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. class_eval needed to be wrapped in a ActiveSupport.on_load(:action_controller) block 2. If the rails version has ::ActionController::API we also add the helper methods there also. 3. ActionView::Base class_eval was clobbering existing controller helpers when not wrapped in a ActiveSupport.on_load(:action_view) block
Rails 5 Support
|
@hassox I can see there hasn't been any activity on this gem for sometime but our company still uses this gem. If you don't have the time to maintain it we would be happy to take over. Thanks! |
|
@hassox any thoughts on letting us manage this gem? |
|
@jspooner I would love you to :) I'm finding my time really split lately and the load off my mind would be great :) |
|
@whithub thoughts on maintaining too? I know you're mostly maintaining warden now and it'd be nice to keep them together |
|
@hassox Do you mind giving me rubygems permissions? |
|
@jspooner |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
When the class_eval methods were not wrapped in an on_load block I was getting strange results where my helpers in the including project were wiped out. I noticed all Railsies in the Rails project has this on_load block.
a) class_eval needed to be wrapped in a ActiveSupport.on_load(:action_controller) block
b) ActionView::Base class_eval was clobbering existing controller helpers when not wrapped in a ActiveSupport.on_load(:action_view) block
If the rails version has ::ActionController::API we also add the helper methods there also.
Rails 5 has a new view on including helpers in controllers. We now call helper vs include
rails/rails#24866