Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rack::Lint not allowing non String variables #104

Closed
joost opened this issue Feb 5, 2015 · 2 comments
Closed

Rack::Lint not allowing non String variables #104

joost opened this issue Feb 5, 2015 · 2 comments

Comments

@joost
Copy link

joost commented Feb 5, 2015

See https://github.com/rack/rack/blob/master/lib/rack/lint.rb#L274:

next  if key.include? "."   # Skip extensions
assert("env variable #{key} has non-string value #{value.inspect}") {

I got this assertion since env['warden'] is the Proxy. Should it be renamed to env['warden.proxy']?

@hassox
Copy link
Collaborator

hassox commented Jun 19, 2015

I'd be down for that. Could you provide a PR?

@joost
Copy link
Author

joost commented Jun 19, 2015

Hmm... long time ago.. I cannot really remember when/why I got this error.
When I come by it I will definitely create a PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants