Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scoped environment config loading #451

Closed

Conversation

tdgroot
Copy link
Contributor

@tdgroot tdgroot commented Nov 15, 2021

This pull request allows developers to provide user-level and project-level customizations to Warden development environments. For example, if a developer wants to create a phpMyAdmin service for all environments, he could create a ~/.warden/environments/includes/db.base.yml or perhaps in <project_dir>/.warden/environments/includes/db.base.yml:

version: "3.5"
services:
  phpmyadmin:
    hostname: ${WARDEN_ENV_NAME}-phpmyadmin
    image: phpmyadmin/phpmyadmin:latest
    environment:
      - PMA_HOST=db
    depends_on:
      db:
        condition: service_started
    labels:
      - traefik.enable=true
      - traefik.http.routers.${WARDEN_ENV_NAME}-phpmyadmin.priority=3
      - traefik.http.routers.${WARDEN_ENV_NAME}-phpmyadmin.tls=true
      - traefik.http.routers.${WARDEN_ENV_NAME}-phpmyadmin.rule=Host(`phpmyadmin.${TRAEFIK_DOMAIN}`)
      - traefik.http.services.${WARDEN_ENV_NAME}-phpmyadmin.loadbalancer.server.port=80

It also allows developers to develop (and share) custom environment types, without having to edit Warden core files.

@navarr
Copy link
Member

navarr commented Nov 15, 2021

Would this resolve #285?

@tdgroot
Copy link
Contributor Author

tdgroot commented Nov 15, 2021

@navarr yes, I do think so. One could change the default image for a given service and warden env up!

@ihor-sviziev
Copy link
Contributor

@davidalger, could you review this PR?

Copy link

@Den4ik Den4ik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tdgroot Good job. It's looks very useful and provide ability to work not only with php 👍

@sszymkowiczpg
Copy link

When to expect this feature to be merged to stable release?
It'll be highly eligible in my project.

@tdgroot
Copy link
Contributor Author

tdgroot commented Nov 30, 2021

Found out that the scoped loading was missing for the Mutagen configuration loading, so I added that!

@ihor-sviziev
Copy link
Contributor

@davidalger please review this PR

@poespas
Copy link

poespas commented Feb 14, 2022

@ Maintainers Whats the status of the PR? +1

@poespas
Copy link

poespas commented Mar 22, 2022

@davidalger Have you had a chance to review this yet? :)

@sszymkowicz
Copy link

@davidalger what can I do to help to merge this PR? 🙏

@sszymkowicz
Copy link

Anyone still interested in this PR?

@davidalger UP

@Den4ik
Copy link

Den4ik commented Aug 10, 2022

I believe that we can create community driven fork due to @davidalger lack of free time

@ihor-sviziev
Copy link
Contributor

@Den4ik, actually, it's already there https://github.com/swiftotter/den/discussions/5

navarr pushed a commit to swiftotter/den that referenced this pull request Sep 8, 2022
Port in wardenenv#451

Signed-off-by: Navarr <navarr@swiftotter.com>
@stale
Copy link

stale bot commented Nov 9, 2022

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale label Nov 9, 2022
@navarr navarr added enhancement New feature or request and removed stale labels Dec 22, 2022
@navarr navarr self-assigned this Dec 22, 2022
@navarr navarr added this to the Warden 1.0.0 milestone Dec 22, 2022
navarr pushed a commit that referenced this pull request Jan 17, 2023
Port in #451

Signed-off-by: Navarr <navarr@swiftotter.com>
@navarr
Copy link
Member

navarr commented Jan 17, 2023

Manually merged from Den in 5a24ca7

@navarr navarr closed this Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

7 participants