Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

landing page improvements #42

Closed
warengonzaga opened this issue Oct 26, 2021 · 12 comments · Fixed by #43, #45, #44, #46 or #41
Closed

landing page improvements #42

warengonzaga opened this issue Oct 26, 2021 · 12 comments · Fixed by #43, #45, #44, #46 or #41
Assignees
@warengonzaga @angelofallars
Labels
chore Issue/Pull Request Label for Housekeeping hacktoberfest Hacktoberfest Related Pull Request or Issue. tweak Issue/Pull Request for Tweaks
Milestone
v2.0.0 📦

Comments

@warengonzaga
Copy link
Owner

Users are suggesting adding some information about buymeacoffee.js usage and why they should use this API wrapper to their project and place that information on the front page.

In addition, I guess we can add the official icon to the landing page @thomasbnt? Aside from the text buymeacoffee.js
@warengonzaga warengonzaga added tweak Issue/Pull Request for Tweaks hacktoberfest Hacktoberfest Related Pull Request or Issue. help wanted Issue Label for Asking Help p3 labels Oct 26, 2021
@warengonzaga warengonzaga added this to the BuyMeaCoffeeJS v2 milestone Oct 26, 2021
@angelofallars
Copy link
Contributor

Sounds good! We can add the official logo to the page right away. Can be on top of the text buymeacoffee.js or besides it. For the information, maybe something about the information the wrapper can get, like supporters data and subscriptions data.

@angelofallars
Copy link
Contributor

angelofallars commented Oct 26, 2021 •
edited
Loading

How does this look? buymeacoffee.js.org with the new logo

Edit: Also preview in mobile

buymeacoffee.js.org preview in mobile

@warengonzaga
Copy link
Owner Author

I prefer the logo on top of the text as it represents the logo. @angelofallars

@angelofallars
Copy link
Contributor

I prefer the logo on top of the text as it represents the logo. @angelofallars

How about this one?

Logo on top

@warengonzaga
Copy link
Owner Author

I prefer the logo on top of the text as it represents the logo. @angelofallars

How about this one?

Logo on top

Perfect! ✨

@angelofallars angelofallars mentioned this issue Oct 26, 2021
Merged
@warengonzaga warengonzaga added the in progress Issue/Pull Request Label for In Progress Status label Oct 26, 2021
@warengonzaga warengonzaga linked a pull request Oct 26, 2021 that will close this issue
add SVG logo to the landing page #43
Merged
@thomasbnt
Copy link
Collaborator

How does this look? buymeacoffee.js.org with the new logo

Edit: Also preview in mobile

buymeacoffee.js.org preview in mobile

The first is cool but without shadow

@warengonzaga
Copy link
Owner Author

How does this look? buymeacoffee.js.org with the new logo
Edit: Also preview in mobile
buymeacoffee.js.org preview in mobile

The first is cool but without shadow

Add your changes to the PR #45 @thomasbnt

This was linked to pull requests Oct 26, 2021
add open graph preview with image for landing page #45
Merged
🚀 RELEASE: v1.2.2 #44
Merged
@thomasbnt
Copy link
Collaborator

I leave this PR to @angelofallars if you want 😉

@angelofallars
Copy link
Contributor

I leave this PR to @angelofallars if you want wink

The logo shadow was already in #43

@thomasbnt
Copy link
Collaborator

I leave this PR to @angelofallars if you want wink

The logo shadow was already in #43

The logo on top is nice on mobile but at the left on desktop seems clear and better. What did you say @warengonzaga ?

We leave that (on top of the text on mobile and desktop) but I remove the shadow? Or I remove shadow + show the logo at the left on desktop and on top on mobile ?

@warengonzaga
Copy link
Owner Author

I leave this PR to @angelofallars if you want wink

The logo shadow was already in #43

The logo on top is nice on mobile but at the left on desktop seems clear and better. What did you say @warengonzaga ?

We leave that (on top of the text on mobile and desktop) but I remove the shadow? Or I remove shadow + show the logo at the left on desktop and on top on mobile ?

I guess we can tweak it in the next update.

This was linked to pull requests Oct 26, 2021
vertical alignment fix #46
Merged
add favicon in SVG format (#37) #41
Merged
@thomasbnt thomasbnt pinned this issue Oct 26, 2021
@warengonzaga warengonzaga added the chore Issue/Pull Request Label for Housekeeping label Nov 16, 2021
@warengonzaga warengonzaga unpinned this issue Nov 16, 2021
@warengonzaga warengonzaga removed in progress Issue/Pull Request Label for In Progress Status help wanted Issue Label for Asking Help labels Dec 3, 2021
@warengonzaga warengonzaga removed the p3 label Dec 3, 2021
@warengonzaga
Copy link
Owner Author

Improved and added a description to the landing page at bf64902

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@warengonzaga warengonzaga

@angelofallars angelofallars

Labels
chore Issue/Pull Request Label for Housekeeping hacktoberfest Hacktoberfest Related Pull Request or Issue. tweak Issue/Pull Request for Tweaks
Projects
None yet
Milestone
v2.0.0 📦
3 participants
@thomasbnt @warengonzaga @angelofallars