Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add open graph preview with image for landing page #45

Merged
merged 4 commits into from
Oct 26, 2021

Conversation

angelofallars
Copy link
Contributor

Adds the Open Graph preview, with title, description and image. The image is not as good as an auto-generated preview but it will do for now.

Preview:

Preview 1

Preview 2

@vercel
Copy link

vercel bot commented Oct 26, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/warengonzaga/buymeacoffeejs/CEs2LVbTNofTNqaopvxo2KtWRJvS
✅ Preview: https://buymeacoffeejs-git-fork-angelofallars-opengraph-warengonzaga.vercel.app

@warengonzaga warengonzaga self-requested a review October 26, 2021 09:38
@warengonzaga warengonzaga added hacktoberfest Hacktoberfest Related Pull Request or Issue. hacktoberfest-accepted Hacktoberfest Accepted Pull Request. tweak Issue/Pull Request for Tweaks labels Oct 26, 2021
@warengonzaga warengonzaga linked an issue Oct 26, 2021 that may be closed by this pull request
Copy link
Owner

@warengonzaga warengonzaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just check my requested changes to be able to merge this PR and add it to the pending release PR. #44

docs/index.html Outdated

<!-- Open Graph / Facebook -->
<meta property="og:type" content="website">
<meta property="og:url" content="https://metatags.io/">
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace this with https://buymeacoffee.js.org which explains why your open graph preview shows this.
image

docs/index.html Outdated

<!-- Twitter -->
<meta property="twitter:card" content="summary_large_image">
<meta property="twitter:url" content="https://metatags.io/">
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same thing here.

docs/index.html Outdated Show resolved Hide resolved
docs/index.html Show resolved Hide resolved
docs/index.html Outdated Show resolved Hide resolved
<meta charset="UTF-8">
<title>buymeacoffee.js</title>
<meta name="description" content="A simple and lightweight but powerful Node.js client for Buy Me a Coffee API.">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<link rel="stylesheet" href="assets/css/styles.css">
<script src="assets/js/script.js"></script>

<meta name="title" content="buymeacoffee.js - API wrapper for Buy Me a Coffee">
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same thing buymeacoffee.js - Official NodeJS API Wrapper for Buy Me a Coffee API

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All done

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll review it again.

@warengonzaga warengonzaga added the waiting response Issue/Pull Request Label for Waiting Response label Oct 26, 2021
@warengonzaga warengonzaga changed the title Add Open Graph preview with image in landing page add open graph preview with image for landing page Oct 26, 2021
Copy link
Owner

@warengonzaga warengonzaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good besides, the title of the page. Don't worry I'll update it instead.

@warengonzaga warengonzaga merged commit a298d44 into warengonzaga:dev Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest Hacktoberfest Related Pull Request or Issue. hacktoberfest-accepted Hacktoberfest Accepted Pull Request. tweak Issue/Pull Request for Tweaks waiting response Issue/Pull Request Label for Waiting Response
Projects
None yet
Development

Successfully merging this pull request may close these issues.

landing page improvements improve opengraph for the landing page
2 participants