-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add open graph preview with image for landing page #45
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/warengonzaga/buymeacoffeejs/CEs2LVbTNofTNqaopvxo2KtWRJvS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just check my requested changes to be able to merge this PR and add it to the pending release PR. #44
docs/index.html
Outdated
|
||
<!-- Open Graph / Facebook --> | ||
<meta property="og:type" content="website"> | ||
<meta property="og:url" content="https://metatags.io/"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docs/index.html
Outdated
|
||
<!-- Twitter --> | ||
<meta property="twitter:card" content="summary_large_image"> | ||
<meta property="twitter:url" content="https://metatags.io/"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same thing here.
<meta charset="UTF-8"> | ||
<title>buymeacoffee.js</title> | ||
<meta name="description" content="A simple and lightweight but powerful Node.js client for Buy Me a Coffee API."> | ||
<meta name="viewport" content="width=device-width, initial-scale=1.0"> | ||
<link rel="stylesheet" href="assets/css/styles.css"> | ||
<script src="assets/js/script.js"></script> | ||
|
||
<meta name="title" content="buymeacoffee.js - API wrapper for Buy Me a Coffee"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same thing buymeacoffee.js - Official NodeJS API Wrapper for Buy Me a Coffee API
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll review it again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good besides, the title of the page. Don't worry I'll update it instead.
Adds the Open Graph preview, with title, description and image. The image is not as good as an auto-generated preview but it will do for now.
Preview: