Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

query string as shortcode #1

Closed
warengonzaga opened this issue Sep 21, 2021 · 8 comments · Fixed by #16
Closed

query string as shortcode #1

warengonzaga opened this issue Sep 21, 2021 · 8 comments · Fixed by #16
Assignees
Labels
feature Issue/Pull Request Label for New Features hacktoberfest Hacktoberfest Related Pull Request or Issue help wanted Issue Label for First Time Contributors in progress Issue/Pull Request Label for In Progress Status

Comments

@warengonzaga
Copy link
Owner

It is useful to display the current query string as a shortcode in some cases.

@warengonzaga warengonzaga self-assigned this Sep 21, 2021
@warengonzaga warengonzaga changed the title Query String as Shortcode query string as shortcode Oct 12, 2021
@warengonzaga warengonzaga added feature Issue/Pull Request Label for New Features help wanted Issue Label for First Time Contributors in review Issue/Pull Request Label for In Review Status hacktoberfest Hacktoberfest Related Pull Request or Issue labels Oct 12, 2021
@ChristofLee
Copy link
Contributor

Hi, I would like to work on this please (I'm looking at #2 as well). I will submit a PR asap.

@warengonzaga
Copy link
Owner Author

Hi @ChristofLee try to submit a PR and I'll check it out.

@ChristofLee
Copy link
Contributor

Please could you clarify for me. Do you mean something like get_query_var() or are you referring the search variable like https://shortcodes-wp.local/?s=sample?

It may be useful if you could provide a use case?

@warengonzaga
Copy link
Owner Author

Please could you clarify for me. Do you mean something like get_query_var() or are you referring the search variable like https://shortcodes-wp.local/?s=sample?

It may be useful if you could provide a use case?

Yes, something like that... display the current parameter link.com/?here=value

Another reference: https://docs.gravityview.co/article/314-the-get-merge-tag

Think of it like a shortcode version instead of a merge tag.

@ChristofLee
Copy link
Contributor

Thanks that makes sense. Please see PR #6.

@warengonzaga
Copy link
Owner Author

Thanks that makes sense. Please see PR #6.

added my requested changes.

@warengonzaga warengonzaga added in progress Issue/Pull Request Label for In Progress Status and removed in review Issue/Pull Request Label for In Review Status labels Oct 16, 2021
@ChristofLee
Copy link
Contributor

#6 has been merged so I believe this issue can be closed now.

@warengonzaga
Copy link
Owner Author

I agree @ChristofLee, closing this now as I merge the update to the dev branch.

@warengonzaga warengonzaga linked a pull request Oct 23, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Issue/Pull Request Label for New Features hacktoberfest Hacktoberfest Related Pull Request or Issue help wanted Issue Label for First Time Contributors in progress Issue/Pull Request Label for In Progress Status
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants