Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

query parameter shortcode #6

Merged

Conversation

ChristofLee
Copy link
Contributor

Add shortcode to display a query string on a page.

The shortcode:
Screenshot 2021-10-16 at 10 22 31

Test URL:
https://shortcodes-wp.local/sample-page/?test=Chistof+Lee

Result:
Screenshot 2021-10-16 at 10 22 15

- Pass the shortcode an arg, the parameter of the query string.
- Clean and return it.
@ChristofLee ChristofLee changed the base branch from main to dev October 16, 2021 09:27
@ChristofLee ChristofLee changed the title 1: Query string shortcode #1 Query string shortcode Oct 16, 2021
@warengonzaga
Copy link
Owner

Hi @ChristofLee I guess instead of [wpuser_query_string] let's change it to [wpinfo_query_param] for query parameters.

@warengonzaga warengonzaga self-requested a review October 16, 2021 09:42
@warengonzaga warengonzaga added feature Issue/Pull Request Label for New Features hacktoberfest Hacktoberfest Related Pull Request or Issue in progress Issue/Pull Request Label for In Progress Status labels Oct 16, 2021
@warengonzaga warengonzaga changed the title #1 Query string shortcode query parameter shortcode Oct 16, 2021
@ChristofLee
Copy link
Contributor Author

Understood. Will do this when I can.

@ChristofLee
Copy link
Contributor Author

Updated as requested.

Copy link
Owner

@warengonzaga warengonzaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good for me @ChristofLee good work!

@warengonzaga warengonzaga removed the in progress Issue/Pull Request Label for In Progress Status label Oct 17, 2021
@warengonzaga warengonzaga merged commit b8fe5a0 into warengonzaga:dev Oct 17, 2021
@warengonzaga warengonzaga added the hacktoberfest-accepted Hacktoberfest Accepted Pull Request label Oct 17, 2021
@ChristofLee ChristofLee deleted the feature/1-query-string-shortcode branch October 24, 2021 19:34
warengonzaga added a commit that referenced this pull request Oct 25, 2021
* add .gitignore (#4)

* Create gitignore

- Create a gitignore file to hide vscode settings

* Add more generic patterns to .gitignore

* 📦 FEATURE: query parameter shortcode (#6)

* Add shortcode for query string

- Pass the shortcode an arg, the parameter of the query string.
- Clean and return it.

* Query string => query paran

* 📦 FEATURE: date shortcodes (#5)

* Current day shortcode

* Current month shortcode

* Current year shortcode

* Current date shortcode

- Give the user some control over the format.

* Get currrent date, not date of post

* Remove debug code

* Add documentation for the date shortcodes

* Add documentation for the query param shortcode

* ✨ TWEAK: namespace for shortcode (#8)

* Current day shortcode

* Current month shortcode

* Current year shortcode

* Current date shortcode

- Give the user some control over the format.

* Get currrent date, not date of post

* Add shortcode for query string

- Pass the shortcode an arg, the parameter of the query string.
- Clean and return it.

* Query string => query paran

* Check function exists before defining one

- Avoid conflicts

* Fix name of shortcode

* ✨ TWEAK: update funding links

* ✨ TWEAK: add contributing file

* ✨ TWEAK: update readme file

* ✨ TWEAK: update announcement info

* ✨ TWEAK: finalize announcement info

* ✨ TWEAK: format file with PHPCBF (#17)

- Use comment format requested by @warengonzaga

Co-authored-by: Christof Lee <christoflee63@gmail.com>
warengonzaga added a commit that referenced this pull request Oct 25, 2021
* 🚀 RELEASE: v1.1.0 update (#16)

* add .gitignore (#4)

* Create gitignore

- Create a gitignore file to hide vscode settings

* Add more generic patterns to .gitignore

* 📦 FEATURE: query parameter shortcode (#6)

* Add shortcode for query string

- Pass the shortcode an arg, the parameter of the query string.
- Clean and return it.

* Query string => query paran

* 📦 FEATURE: date shortcodes (#5)

* Current day shortcode

* Current month shortcode

* Current year shortcode

* Current date shortcode

- Give the user some control over the format.

* Get currrent date, not date of post

* Remove debug code

* Add documentation for the date shortcodes

* Add documentation for the query param shortcode

* ✨ TWEAK: namespace for shortcode (#8)

* Current day shortcode

* Current month shortcode

* Current year shortcode

* Current date shortcode

- Give the user some control over the format.

* Get currrent date, not date of post

* Add shortcode for query string

- Pass the shortcode an arg, the parameter of the query string.
- Clean and return it.

* Query string => query paran

* Check function exists before defining one

- Avoid conflicts

* Fix name of shortcode

* ✨ TWEAK: update funding links

* ✨ TWEAK: add contributing file

* ✨ TWEAK: update readme file

* ✨ TWEAK: update announcement info

* ✨ TWEAK: finalize announcement info

* ✨ TWEAK: format file with PHPCBF (#17)

- Use comment format requested by @warengonzaga

Co-authored-by: Christof Lee <christoflee63@gmail.com>

* docs: update README.md [skip ci]

* docs: create .all-contributorsrc [skip ci]

Co-authored-by: Waren Gonzaga <opensource@warengonzaga.com>
Co-authored-by: Christof Lee <christoflee63@gmail.com>
Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Issue/Pull Request Label for New Features hacktoberfest Hacktoberfest Related Pull Request or Issue hacktoberfest-accepted Hacktoberfest Accepted Pull Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants