-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
query parameter shortcode #6
Merged
warengonzaga
merged 2 commits into
warengonzaga:dev
from
ChristofLee:feature/1-query-string-shortcode
Oct 17, 2021
Merged
query parameter shortcode #6
warengonzaga
merged 2 commits into
warengonzaga:dev
from
ChristofLee:feature/1-query-string-shortcode
Oct 17, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Pass the shortcode an arg, the parameter of the query string. - Clean and return it.
Closed
Hi @ChristofLee I guess instead of |
Understood. Will do this when I can. |
Updated as requested. |
warengonzaga
approved these changes
Oct 17, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good for me @ChristofLee good work!
warengonzaga
added a commit
that referenced
this pull request
Oct 25, 2021
* add .gitignore (#4) * Create gitignore - Create a gitignore file to hide vscode settings * Add more generic patterns to .gitignore * 📦 FEATURE: query parameter shortcode (#6) * Add shortcode for query string - Pass the shortcode an arg, the parameter of the query string. - Clean and return it. * Query string => query paran * 📦 FEATURE: date shortcodes (#5) * Current day shortcode * Current month shortcode * Current year shortcode * Current date shortcode - Give the user some control over the format. * Get currrent date, not date of post * Remove debug code * Add documentation for the date shortcodes * Add documentation for the query param shortcode * ✨ TWEAK: namespace for shortcode (#8) * Current day shortcode * Current month shortcode * Current year shortcode * Current date shortcode - Give the user some control over the format. * Get currrent date, not date of post * Add shortcode for query string - Pass the shortcode an arg, the parameter of the query string. - Clean and return it. * Query string => query paran * Check function exists before defining one - Avoid conflicts * Fix name of shortcode * ✨ TWEAK: update funding links * ✨ TWEAK: add contributing file * ✨ TWEAK: update readme file * ✨ TWEAK: update announcement info * ✨ TWEAK: finalize announcement info * ✨ TWEAK: format file with PHPCBF (#17) - Use comment format requested by @warengonzaga Co-authored-by: Christof Lee <christoflee63@gmail.com>
warengonzaga
added a commit
that referenced
this pull request
Oct 25, 2021
* 🚀 RELEASE: v1.1.0 update (#16) * add .gitignore (#4) * Create gitignore - Create a gitignore file to hide vscode settings * Add more generic patterns to .gitignore * 📦 FEATURE: query parameter shortcode (#6) * Add shortcode for query string - Pass the shortcode an arg, the parameter of the query string. - Clean and return it. * Query string => query paran * 📦 FEATURE: date shortcodes (#5) * Current day shortcode * Current month shortcode * Current year shortcode * Current date shortcode - Give the user some control over the format. * Get currrent date, not date of post * Remove debug code * Add documentation for the date shortcodes * Add documentation for the query param shortcode * ✨ TWEAK: namespace for shortcode (#8) * Current day shortcode * Current month shortcode * Current year shortcode * Current date shortcode - Give the user some control over the format. * Get currrent date, not date of post * Add shortcode for query string - Pass the shortcode an arg, the parameter of the query string. - Clean and return it. * Query string => query paran * Check function exists before defining one - Avoid conflicts * Fix name of shortcode * ✨ TWEAK: update funding links * ✨ TWEAK: add contributing file * ✨ TWEAK: update readme file * ✨ TWEAK: update announcement info * ✨ TWEAK: finalize announcement info * ✨ TWEAK: format file with PHPCBF (#17) - Use comment format requested by @warengonzaga Co-authored-by: Christof Lee <christoflee63@gmail.com> * docs: update README.md [skip ci] * docs: create .all-contributorsrc [skip ci] Co-authored-by: Waren Gonzaga <opensource@warengonzaga.com> Co-authored-by: Christof Lee <christoflee63@gmail.com> Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature
Issue/Pull Request Label for New Features
hacktoberfest
Hacktoberfest Related Pull Request or Issue
hacktoberfest-accepted
Hacktoberfest Accepted Pull Request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add shortcode to display a query string on a page.
The shortcode:
![Screenshot 2021-10-16 at 10 22 31](https://user-images.githubusercontent.com/4659534/137582403-61355b31-a5ef-4f61-bd30-063de19c889b.png)
Test URL:
https://shortcodes-wp.local/sample-page/?test=Chistof+Lee
Result:
![Screenshot 2021-10-16 at 10 22 15](https://user-images.githubusercontent.com/4659534/137582408-fb2ce60a-8da9-408d-9e81-df34ba1c0206.png)