-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New backend seeds and documentation adjustments #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dimitris Kargatzis <dkargatzis@gmail.com>
Signed-off-by: Dimitris Kargatzis <dkargatzis@gmail.com>
Signed-off-by: Dimitris Kargatzis <dkargatzis@gmail.com>
Signed-off-by: Dimitris Kargatzis <dkargatzis@gmail.com>
Signed-off-by: Dimitris Kargatzis <dkargatzis@gmail.com>
Signed-off-by: Dimitris Kargatzis <dkargatzis@gmail.com>
dimeloper
requested changes
Oct 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest that we keep the naming structure consistent, like:
(runtime-)language-framework-frameworkVariant
- In this case
node-express-js
should benode-js-express
. node-express-mogoose-js
should benode-js-express-mongoose
.node-epxress-starter-js
should benode-js-express-starter
.
Such a structure except from consistency would also offer better sorting (if e.g. I'm looking for js variants or ts variants)
Signed-off-by: Dimitris Kargatzis <dkargatzis@gmail.com>
dimeloper
approved these changes
Oct 18, 2023
Signed-off-by: Dimitris Kargatzis <dkargatzis@gmail.com>
Signed-off-by: Dimitris Kargatzis <dkargatzis@gmail.com>
Signed-off-by: Dimitris Kargatzis <dkargatzis@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
[Add a short title for your pull request here]
Description
[Describe the changes made by this pull request and why they are necessary.]
Related Issues
[List any related issues or pull requests that this pull request addresses]
Type of change
Screenshots (if applicable)
[Include any relevant screenshots to help explain the changes made by this pull request]
Checklist
Please add an
x
inside the square brackets to check off each item in the checklist.Additional Notes (if applicable)
[Include any additional notes or context that might be helpful for reviewers]