Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New backend seeds and documentation adjustments #2

Merged
merged 11 commits into from
Oct 26, 2023

Conversation

dkargatzis
Copy link
Member

Title

[Add a short title for your pull request here]

Description

[Describe the changes made by this pull request and why they are necessary.]

Related Issues

[List any related issues or pull requests that this pull request addresses]

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Screenshots (if applicable)

[Include any relevant screenshots to help explain the changes made by this pull request]

Checklist

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have tested my changes thoroughly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Please add an x inside the square brackets to check off each item in the checklist.

Additional Notes (if applicable)

[Include any additional notes or context that might be helpful for reviewers]

Signed-off-by: Dimitris Kargatzis <dkargatzis@gmail.com>
Signed-off-by: Dimitris Kargatzis <dkargatzis@gmail.com>
Signed-off-by: Dimitris Kargatzis <dkargatzis@gmail.com>
Signed-off-by: Dimitris Kargatzis <dkargatzis@gmail.com>
Signed-off-by: Dimitris Kargatzis <dkargatzis@gmail.com>
Signed-off-by: Dimitris Kargatzis <dkargatzis@gmail.com>
Copy link
Collaborator

@dimeloper dimeloper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest that we keep the naming structure consistent, like:

(runtime-)language-framework-frameworkVariant

  • In this case node-express-js should be node-js-express.
  • node-express-mogoose-js should be node-js-express-mongoose.
  • node-epxress-starter-js should be node-js-express-starter.

Such a structure except from consistency would also offer better sorting (if e.g. I'm looking for js variants or ts variants)

Signed-off-by: Dimitris Kargatzis <dkargatzis@gmail.com>
Signed-off-by: Dimitris Kargatzis <dkargatzis@gmail.com>
Signed-off-by: Dimitris Kargatzis <dkargatzis@gmail.com>
Signed-off-by: Dimitris Kargatzis <dkargatzis@gmail.com>
@dkargatzis dkargatzis merged commit 44ee874 into main Oct 26, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants