New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove duktape and use QuickJS #295
Conversation
Cool! happy to see the relative paths. But i can't get it to compile: With make
and i assume you will deprecate the makefile :? and abandon the With meson/ninja
the fix is this:
after this i managed to get it working, at least with small functions. otherwise i get an error (which maybe affects master, didnt tried) another thing i noticed is this
Do you have some numbers about the performance? hope the whole codebase gets some es6 improvements after merging this |
i haven't tested time differences. |
So it is ready for testing then? i can make up some numbers |
looks like there are some issues on windows (tests) but for me can be tested |
i need to still apply your changes |
I have fixed windows build and the issue you had. i cannot tho fix the debian package or the macos one |
I did some tests:
building with is there a way to install the plugin in the home? because ninja -C b install is putting things in the system path always |
just do |
yeah thing is that home directory doesnt follow system structure, but thats not really a blocker for me, so im good to get this merged. i have a bunch of other improvements but i would prefer to get this merged before moving forward. Good work! |
@trufae this adds support to r2dec to use quickjs
unfortunately i couldn't use the code you implemented because i wanted to also support the ci.
i had to remove the Makefile version.