SaveGlobal function does not save "/" character correctly

[timfel]

The "std::string SaveGlobal(lua_State *l, bool is_root, std::vectorstd::string &blockTableNames)" function, in script.cpp, does not save the "/" character correctly in strings, potentially causing crashes when a game is loaded. For example, if we have the following string:

"The name "Marcomanni" means "march-men", or "frontier-men"."

...it will be saved as:

"The name "Marcomanni" means "march-men", or "frontier-men"."

...which will cause a crash upon game load.

---

Imported from Launchpad using lp2gh.

• date created: 2015-03-01T10:53:40Z
• owner: andre-ng
• assignee: iddqd-mail
• the launchpad url was https://bugs.launchpad.net/bugs/1426857

[timfel]

(by iddqd-mail)
Try to use "" combination to save "" symbol

[timfel]

(by andre-ng)
Wouldn't that just mean that the crash would happen after loading two games, instead of one?

When loading the first game, "" would be converted to "". And then, if the player saves the game again, this new save will become corrupt (because the "" will disappear), and cause a crash upon loading.

[timfel]

(by iddqd-mail)
Fixed in rev.8963

[timfel]

(by andre-ng)
thanks :)