Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Door changes won't set the UnsavedChanges bool to be true #210

Closed
shinespeciall opened this issue May 25, 2020 · 1 comment · Fixed by #441
Closed

Door changes won't set the UnsavedChanges bool to be true #210

shinespeciall opened this issue May 25, 2020 · 1 comment · Fixed by #441
Labels
bug Something isn't working correctly low-priority The issue is not a major prioritization when considering new work. new-contributor-friendly the issue can be a good start if a new contributor want to join us

Comments

@shinespeciall
Copy link
Member

The title says it. this can only be fixed after the door undo/redo features being added.
@shinespeciall shinespeciall added bug Something isn't working correctly low-priority The issue is not a major prioritization when considering new work. labels May 25, 2020
@shinespeciall shinespeciall added the new-contributor-friendly the issue can be a good start if a new contributor want to join us label Jun 14, 2020
@shinespeciall
Copy link
Member Author

UnsavedChanges bool is a veriable in the WL4EditorWindow class, the door things and several other level ranged things will always be saved every time UnsavedChanges equal to true and the user try to save changes, this should be an easy fix. But we need to wait for the implementation of door undo & redo first, so the UnsavedChanges bool reset can be in some more suitable place in opertion code.

@shinespeciall shinespeciall mentioned this issue Apr 24, 2023
Closed
shinespeciall added a commit that referenced this issue Apr 24, 2023
@shinespeciall
Fix #442 , Fix #210
b1383f8
@shinespeciall shinespeciall mentioned this issue Apr 24, 2023
Merged
shinespeciall added a commit that referenced this issue Apr 24, 2023
@shinespeciall
Several hotfixes 20230425 (#441)
08c70e3 
* fix an edge case bug in patch path saving

* Fix #442 , Fix #210
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working correctly low-priority The issue is not a major prioritization when considering new work. new-contributor-friendly the issue can be a good start if a new contributor want to join us
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Several hotfixes 20230425 wario-land/WL4Editor
1 participant
@shinespeciall