Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the repository name to container-image-csi-driver #105

Open
mugdha-adhav opened this issue Jan 10, 2024 · 6 comments · Fixed by #126
Open

Change the repository name to container-image-csi-driver #105

mugdha-adhav opened this issue Jan 10, 2024 · 6 comments · Fixed by #126
Assignees
Labels
work-in-progress Someone is working on this already

Comments

@mugdha-adhav
Copy link
Collaborator

See #91 for more details.

@mugdha-adhav
Copy link
Collaborator Author

mugdha-adhav commented Jan 13, 2024

Noting down some of the action items I could think of -

  • Change repository name in GitHub settings.
  • Change default branch to main from master.
  • Update go dependency files (go.mod & go.sum).
  • Update the references of repository name while running integration tests.
  • Test and update the Make targets.
  • Update image name to container-image-csi-driver in manifests and update registry references.

Because most of the above mentioned points are inter-dependent and would cause breaking changes, I think we should have a single PR for all the identified changes.

@mugdha-adhav
Copy link
Collaborator Author

Adding links to some reference reading material I found -

@mbtamuli
Copy link
Contributor

Because most of the above mentioned points are inter-dependent and would cause breaking changes, I think we should have a single PR for all the identified changes.

Can we also add one more thing to this? Renaming the master branch to main - https://github.com/github/renaming#renaming-existing-branches. It would also cause breaking changes, at least for existing forks. Better to rip-off the band-aid in one go.

@mugdha-adhav mugdha-adhav self-assigned this Jan 20, 2024
@mugdha-adhav mugdha-adhav added the work-in-progress Someone is working on this already label Jan 21, 2024
@mugdha-adhav
Copy link
Collaborator Author

Updated README with the name change notice.

@mbtamuli
Copy link
Contributor

FYI @mugdha-adhav, Argo Workflows also renamed the default branch - argoproj/argo-workflows#12127

@mbtamuli
Copy link
Contributor

@mugdha-adhav I'm creating a PR for fixing the workflows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
work-in-progress Someone is working on this already
Projects
None yet
2 participants