Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update references for old repository name #127

Merged
merged 8 commits into from
Jan 22, 2024

Conversation

mugdha-adhav
Copy link
Collaborator

@mugdha-adhav mugdha-adhav commented Jan 22, 2024

Related to #105

Updating references for csi-driver-image to container-image-csi-driver in the listed files/packages.

  • go.mod
  • package imports
  • Dockerfiles
  • docs
  • scripts

@mugdha-adhav
Copy link
Collaborator Author

Waiting on CI builds to be fixed in #126 before we merge this PR.

@mugdha-adhav mugdha-adhav added the work-in-progress Someone is working on this already label Jan 22, 2024
@mbtamuli
Copy link
Contributor

mbtamuli commented Jan 22, 2024

Not sure why it's not getting triggered in your case. Maybe it's related to the repository name/branch changes. I had updated the HEAD for both origin and upstream as opposed to just origin as mentioned here - https://github.com/warm-metal/container-image-csi-driver#note-for-forked-repositories

git branch -m master main
git remote set-url upstream git@github.com:warm-metal/container-image-csi-driver.git
git remote set-url origin git@github.com:mbtamuli/container-image-csi-driver.git
git fetch origin
git fetch upstream
git branch -u main main
git remote set-head origin -a
git remote set-head upstream -a

Are you sure you've updated your fork correctly? For #126, the workflows are getting triggered.

* Update go.mod
* Update package imports
* Update Dockerfiles
* Update docs
* Update scripts
@mugdha-adhav
Copy link
Collaborator Author

Are you sure you've updated your fork correctly? For #126, the workflows are getting triggered.

I think the workflows got triggered for #126 because it had the changes to fix the CI. As for updating my fork, I re-created my fork after name change so I don't think the issue is related to my fork.

And now the workflows got triggered after I rebased this PR with your CI changes.

@mbtamuli
Copy link
Contributor

"image": "ghcr.io/warm-metal/csi-driver-image/devcontainer:latest",

@mugdha-adhav Please change the name as well in your PR

-	"image": "ghcr.io/warm-metal/csi-driver-image/devcontainer:latest",
+	"image": "ghcr.io/warm-metal/container-image-csi-driver/devcontainer:latest",

* Update docker images for tests
* Fix make targets for test-deps
@mugdha-adhav
Copy link
Collaborator Author

@mugdha-adhav Please change the name as well in your PR

Not just the name, but I think we'll also need to update all the references of csi-driver-image in the devcontainer.json files. Working on it.

@mugdha-adhav
Copy link
Collaborator Author

I tried updating all references of older repository in a single PR, but it's getting too large and hard to track.

Reverted some of the recent commits. Will create separate PRs for those changes.

@mbtamuli JFYI, your dev-container related change will also go in one of the follow up PR.

README.md Outdated Show resolved Hide resolved
@mbtamuli
Copy link
Contributor

your dev-container related change will also go in one of the follow up PR.

@mugdha-adhav I understand. I'll take care of raising a PR related to any devcontainer updates.

Co-authored-by: Mriyam Tamuli <mbtamuli@gmail.com>
@mugdha-adhav mugdha-adhav merged commit 282bd48 into warm-metal:main Jan 22, 2024
6 checks passed
@mugdha-adhav mugdha-adhav deleted the chore/update-go-deps branch January 22, 2024 13:56
@mugdha-adhav mugdha-adhav removed the work-in-progress Someone is working on this already label Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants