Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX 🛠️] Cart Button looks ugly #161

Merged

Conversation

AnsellMaximilian
Copy link
Contributor

@AnsellMaximilian AnsellMaximilian commented Oct 17, 2023

Issue #160

Guidelines 🔐

I accept the fact that I have followed the guidelines and have not copied the codes from around the internet

  • Contribution Guidelines
  • Code of Conduct

Issue to be closed 🛅

Screenshots 📷

Here are the pictures of changes that I have made 🔽

image

I have removed the absolute positioning of the cart icon and moved it to be on the same horizontal level of the price. The shopping cart icon is now responsive on small screens.

@vercel
Copy link

vercel bot commented Oct 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nike ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2023 2:59am

@github-actions github-actions bot added hacktoberfest This issue/pull request is specially marked for hacktoberfest 🐞 bug 🛠 goal: fix labels Oct 17, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @AnsellMaximilian, thank you for raising a pull request.

Please make sure you have filled the PR template properly and followed our contributing guidelines.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations 🎉 @AnsellMaximilian, on your first contribution in Nike

  • Make sure to star this project, if you liked contributing to it. 🌟🌟🌟
  • You can raise another new issue, if you find something is worth enhancement or needs a fix.
  • You can see my other projects too, which you might feel appealing.
  • You also follow me for making more future contributions in open-source projects.

Copy link
Owner

@warmachine028 warmachine028 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@warmachine028 warmachine028 changed the title fix shopping cart icon [FIX 🛠️] Cart Button looks ugly Oct 17, 2023
@warmachine028 warmachine028 added the hacktoberfest-accepted The contribution was accepted for hactoberfest label Oct 17, 2023
@warmachine028 warmachine028 merged commit 8dd6acd into warmachine028:main Oct 17, 2023
9 checks passed
@AnsellMaximilian AnsellMaximilian deleted the #160-fix-cart-button branch October 17, 2023 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug 🛠 goal: fix hacktoberfest This issue/pull request is specially marked for hacktoberfest hacktoberfest-accepted The contribution was accepted for hactoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG 🐞] Cart Button looks ugly
2 participants