-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes #21
fixes #21
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @jakepears, thank you for raising a pull request.
Please make sure you have filled the PR template properly and followed our contributing guidelines.
@jake great to see you made a contribution to this project.However you need to get assigned to the issue first, before contributing. This PR will be kept open. But you are to get assigned to the issue first. |
ok, do i have to resubmit the pull request? what do i redo on my end? |
No need to resubmit. Just get assigned to the issue first @jakepears |
I really like the changes you made to the footer of this website, really impressive. |
thank you😛 |
^ this pull requests consists of a few fixes on the hover activity, various typos, and working towards a cleaner experience. also added a hover animation to the social media buttons on the footer. thank you. (i just needed a green dot on my github graph tbh) |
Congratulations 🎉 @jakepears on your first contribution in Nike
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
Let me know what you think of my implementations. I could always use the boost I get for contributing, so if okay i'd like to keep adding features:) |
Issue #16 📐
Guidelines 🔐
I accept the fact that i have followed the guidelines and have not copied the codes from around the internet
:besides code from my own repos, which shouldn't count
Issue to be closed 🛅
My pull request closes [FEATURE] Card Hover animations #16
Also helped out to add some hover animations on other things; footer, buttons, and navbar.