Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #21

Merged
merged 4 commits into from
Sep 1, 2023
Merged

fixes #21

merged 4 commits into from
Sep 1, 2023

Conversation

jakepears
Copy link
Contributor

@jakepears jakepears commented Aug 29, 2023

Issue #16 📐

Guidelines 🔐

I accept the fact that i have followed the guidelines and have not copied the codes from around the internet
:besides code from my own repos, which shouldn't count

  • Contribution Guidelines
  • Code of Conduct

Issue to be closed 🛅


@vercel
Copy link

vercel bot commented Aug 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nike ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 1, 2023 11:24pm

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @jakepears, thank you for raising a pull request.

Please make sure you have filled the PR template properly and followed our contributing guidelines.

@warmachine028
Copy link
Owner

@jake great to see you made a contribution to this project.

However you need to get assigned to the issue first, before contributing. This PR will be kept open. But you are to get assigned to the issue first.

@jakepears
Copy link
Contributor Author

ok, do i have to resubmit the pull request? what do i redo on my end?

@warmachine028
Copy link
Owner

warmachine028 commented Aug 29, 2023

No need to resubmit. Just get assigned to the issue first @jakepears

@warmachine028
Copy link
Owner

warmachine028 commented Aug 30, 2023

I really like the changes you made to the footer of this website, really impressive.

@jakepears
Copy link
Contributor Author

jakepears commented Sep 1, 2023

I really like the changes you made to the footer of this website, really impressive.

thank you😛

@jakepears
Copy link
Contributor Author

^ this pull requests consists of a few fixes on the hover activity, various typos, and working towards a cleaner experience. also added a hover animation to the social media buttons on the footer. thank you.

(i just needed a green dot on my github graph tbh)

@warmachine028 warmachine028 merged commit 25af3b2 into warmachine028:main Sep 1, 2023
4 checks passed
@warmachine028
Copy link
Owner

Congratulations 🎉 @jakepears on your first contribution in Nike

  • Make sure to star this project, if you liked contributing to it. 🌟🌟🌟
  • You can raise another new issue, if you find something is worth enhancement or needs a fix.
  • You can see my other projects too, which you might feel appealing.
  • You also follow me for making more future contributions in open source projects.

Copy link
Owner

@warmachine028 warmachine028 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@jakepears
Copy link
Contributor Author

Let me know what you think of my implementations. I could always use the boost I get for contributing, so if okay i'd like to keep adding features:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Card Hover animations
2 participants