config: introduce integer LWS_LIBRARY_VERSION_NUMBER, micro numbering #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the current LWS_LIBRARY_VERSION macro is a string, which makes it hard to test for version-dependent features in using code. This patch adopts the Google version number method, which encodes a version as an integer as 'major * 10^6 + minor * 10^3 + micro'. This makes it easy to test: #if defined(LWS_LIBRARY_VERSION_NUMBER) && (LWS_LIBRARY_VERSION_NUMBER > 1003000) // use feature introduced post 1.3.0 #endif Also, spin out version information into a separate include since including library build information from lws_config.h is a bad idea as it interferes with using code. Signed-off-by: Michael Haberler <git@mah.priv.at>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the current LWS_LIBRARY_VERSION macro is a string, which makes it hard
to test for version-dependent features in using code.
This patch adopts the Google version number method, which encodes a version
as an integer as 'major * 10^6 + minor * 10^3 + micro'.
This makes it easy to test:
if defined(LWS_LIBRARY_VERSION_NUMBER) && (LWS_LIBRARY_VERSION_NUMBER > 1003000)
endif
Also, spin out version information into a separate include since
including library build information from lws_config.h is a bad idea as
it interferes with using code.
Signed-off-by: Michael Haberler git@mah.priv.at