Partition table too small for newer esp-idf

[FredrikFornstad]

Hi,
Using the latest esp-idf (and libwebsockets) master (todays date) causes the lws-esp32-factory.bin to be around 1 072 000 bytes, which is larger than the 1M allocated in the partition.csv file. It does work to flash and run, but when flashing the lws-esp32-test-server-demos app, parts of the factory app will be overwritten and after that the factory app starts looking weird...

Proposed solution: Increase the factory partition to 0x110000 in size and shrink the ota partition with 0x10000 in the csv file.

A side note: The partition.csv file for the lws-esp32-test-server-demos app is different. Not sure if it matters in this case. But it looks a bit odd in my Eyes.

[FredrikFornstad]

Oh, I almost forgot: The libwebsockets/scripts/esp32.mk need to have its lws_flash_ota address adjusted accordingly. With my suggested change of increasing the factory partition with 0x10000 the line

write_flash 0x110000 $(LWS_BUILD_PATH)/$(PROJECT_NAME).bin should be changed to
write_flash 0x120000 $(LWS_BUILD_PATH)/$(PROJECT_NAME).bin

[lws-team]

Thanks... yes there's no point having a partition.csv in the test app, I removed it.

I followed your suggestion and added 64KB to the factory partition, shrinking the OTA (and the erase ota) accordingly.

Your following and reporting on esp-idf is really useful, I appreciate the reports.

[FredrikFornstad]

The test-app does not compile out of the box anymore. The user will need to run "make menuconfig" first and set the partition table to one of the defaults. Otherwise the compiler will stop, complaining that it cannot find partitions.csv ... Sure, the user can do this, but I think it is nice if this was done already in the source files. It certainly gives a better impression to a new user that is trying this out for the first time.

[lws-team]

Yeah it shouldn't break it. I replaced it with a copy of the -factory one.