Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a service to allow equivalent of search/wsuser #416

Closed
rfay opened this issue Jun 16, 2014 · 9 comments
Closed

Add a service to allow equivalent of search/wsuser #416

rfay opened this issue Jun 16, 2014 · 9 comments
Labels

Comments

@rfay
Copy link
Contributor

rfay commented Jun 16, 2014

The Android app is using search/wsuser directly because it provides a simple search capability (full name, town, email) all in one string. However, the app is currently scraping to use it, which makes it fragile. (See warmshowers/wsandroid#69)

It should be easy to refactor and move the search/wsuser (hook_search) stuff into a place where it can be wrapped by a RESTful service, making this more robust.

wsuser_search is an invocation of hook_search(). The thing we have to do is wrap the query part so it's usable by both the service and hook_search.

@klzig
Copy link

klzig commented Jun 16, 2014

I'll add search to the windows app if you add it to the REST service.

@tmelz
Copy link

tmelz commented Sep 11, 2014

Any plans to implement this soon?

@rfay
Copy link
Contributor Author

rfay commented Sep 12, 2014

No immediate plans PRs are welcome.

@rfay
Copy link
Contributor Author

rfay commented Oct 2, 2014

Working on this soon. The biggest problem with the android app (warmshowers/wsandroid#73) really just cascades from the lack of this.

@klzig
Copy link

klzig commented Oct 2, 2014

Good timing for the WP app, I'm about to begin working on an update.

@rfay
Copy link
Contributor Author

rfay commented Oct 2, 2014

Added hosts by_keyword in e3943ea

@rfay
Copy link
Contributor Author

rfay commented Oct 2, 2014

@rfay rfay closed this as completed Oct 2, 2014
@klzig
Copy link

klzig commented Oct 2, 2014

Thanks Randy! Will this return users who are currently unavailable?

@rfay
Copy link
Contributor Author

rfay commented Oct 2, 2014

Yes, just like the warmshowers.org/search/wsuser, it can be used to search for any user. The currently available member of the array though lets you know what the status is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants