Make Violation messages for arguments and answers include the method name

[daira]

Make Violation messages for arguments and answers include the method name. fixes #201

Signed-off-by: David-Sarah Hopwood david-sarah@jacaranda.org

[warner]

Finally digging into this. The basic patch looks good, although it makes the tests fail (test_appserver, test_banana.TestCall, test_keepalive, at least). Probably something shallow. I'd like to add a test for the new functionality too.

[warner]

Ah, yeah, it was shallow: Brokers do not always have a methodSchema, and this is exercised by the unit tests. I pushed a "pr12" branch with the additional fix. The next chance I get (or if someone else beats me to it :), I'll add a proper test.

[daira]

Thanks!

[warner]

Hm, this is tricky to test. The first change requires us to provoke a failure during outbound serialization of the arguments (but after the static schema check has passed, so it's not as simple as violating the schema). The second change requires a failure to occur during the remote serialization of the response, again after the static schema check.

One trick that might help would be an object with custom serialization logic, which returns one kind of value the first time it is queried, and a different (failing) value the second time.

[warner]

I've landed this, but it'd still be nice to get some explicit tests for it at some point.