fix incompatibility with Twisted 13.1.0 #14
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fix is to stop using a locally-defined "getPage" which does better clean-up-after-itself with the standard twisted.web.client.getPage instead. (By the way, I disapprove of cleaning-up-after-oneself. Instead, whenever one is done with one's job, the entire universe in which one lives gets destroyed.)
|
rebased and landed in 9a87c87 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix is to stop using a locally-defined "getPage" which does better
clean-up-after-itself with the standard twisted.web.client.getPage instead. (By
the way, I disapprove of cleaning-up-after-oneself. Instead, whenever one is
done with one's job, the entire universe in which one lives gets destroyed.)