Add Socks5 client plugin #21
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: foolscap/pb.py
|
|
||
| @implementer(IConnectionHintHandler) | ||
| class SocksPlugin: | ||
| def __init__(self, socks_host, socks_port, proxy_endpoint_generator=default_tcp4_endpoint_generator): |
There was a problem hiding this comment.
You can replace default_tcp4_endpoint_generator with endpoints.TCP4ClientEndpoint and remove the default_tcp4_endpoint_generator function above.
|
We suggested changes in david415#1 |
|
@warner this PR (plus the minor changes in david415#1) seems a good implementation of what we talked about, and should be enough to get Tahoe Tor support. I guess the next step is merging/releasing this if you like it, and then we can move on to merging support in Tahoe. |
Minor Socks plugin changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found warner's tor branch and was inspired to make this very minimal socks client plugin that only depends on txsocksx. I think getting this to work with tahoe would be a great first step towards native Tor integration from Tahoe-LAFS.