implement the transport plugins using the twisted/zope IPlugin interface #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: foolscap/pb.py
Conflicts: setup.py src/foolscap/connection_plugins.py
here we also reuse the proxy endpoint for additional socks connections with this endpoint instance
…t failed here we change the SOCKS5 plugin class to raise PluginDependencyNotLoaded in it's constructor if txsocksx previously failed to import
here we also make the setup.py install the twisted plugins
|
I think we've decided to not use automatic plugin discovery for this, but to oblige applications to install whatever connection handlers they want to enable (since most handlers will require configuration, and that configuration has to come from somewhere user-facing, and neither foolscap nor plugins have anything particularly user-facing). So I'm gonna say we shouldn't land this one. What do you think? |
|
closing this as WONTFIX, we're going to leave applications (and not foolscap) responsible for discovering/configuring/installing connection handlers. thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.