test_connection: stop using internal Twisted attributes #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes Unknown when pulling 0604a4a on new-twisted into ** on master**. |
This test was checking private attributes of HostnameEndpoint. These were renamed on Twisted trunk sometime after Twisted-16.6.0, so they'll break the Foolscap tests once the next Twisted release comes out (probably 17.0.0). This fixes the tests to use a less fragile approach.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test was checking private attributes of HostnameEndpoint. These were
renamed on Twisted trunk sometime after Twisted-16.6.0, so they'll break the
Foolscap tests once the next Twisted release comes out (probably 17.0.0).
This fixes the tests to use a less fragile approach.