Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

To fix issue #108 #109

Closed
wants to merge 1 commit into from
Closed

To fix issue #108 #109

wants to merge 1 commit into from

Conversation

kcorlidy
Copy link
Contributor

fixed the issue that keys.py#Line89 using the wrong parameter

@kcorlidy
To fix issue #108
0d81989 
fixed the issue that (Line89)[https://github.com/warner/python-ecdsa/blob/master/src/ecdsa/keys.py#L89] using the wrong parameter
@coveralls
Copy link

Coverage Status

Coverage remained the same at 86.484% when pulling 0d81989 on kcorlidy:patch-1 into 480b5f7 on warner:master.

tomato42
tomato42 approved these changes Jul 18, 2019
View reviewed changes
Copy link
Member

@tomato42 tomato42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, but I'd rather not merge with CI failing

could you try fixing the CI in separate PR (I'll be busy for the next week, so the earliest I could try fixing it myself is next Friday)?

@kcorlidy
Copy link
Contributor Author

It looks like the python3.3 could not run the tox version which above 2.5, because there is no contextlib.suppress. through my test, tox <= 2.5 failed, <2.5 succeed, so the latest one python3.3 can use might be tox 2.4.1. https://travis-ci.org/kcorlidy/python-ecdsa/builds/560858735.

@kcorlidy
Copy link
Contributor Author

I ever tried to install contextlib2 first, but the result was unexpected it did not work, because importlib-metadata still chooses to use contextlib. Now, my A choice is downgrade tox to 2.4.1. B choice is downgrade pluggy to 0.5.2.

  • In situation A, can only use tox 2.4.1.
  • In situation B, keep using tox 2.9.1(tox<3). So i suggest this one. my test

@tomato42
Copy link
Member

I don't have a preference, either option is fine

@kcorlidy kcorlidy closed this Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomato42 tomato42 tomato42 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kcorlidy @coveralls @tomato42