Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(shadows): add default box-shadow values to generic shadow classes #96

Merged
merged 3 commits into from May 3, 2023
Merged

fix(shadows): add default box-shadow values to generic shadow classes #96

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
82100c2
fix(shadows): add default box-shadow values to generic shadow classes
BalbinaK May 3, 2023
b6f8691
Update src/_rules/shadow.js
BalbinaK May 3, 2023
c92adde
test: update shadow snapshots
BalbinaK May 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 10 additions & 4 deletions src/_rules/shadow.js
View file
Open in desktop
@@ -1,6 +1,12 @@
const defaultColor = 'rgba(0, 0, 0, .2)';

const boxShadowDefaults = {
small: `0 1px 6px ${defaultColor}, 0 1px 1px ${defaultColor}`,
medium: `0 3px 8px ${defaultColor}, 0 3px 6px ${defaultColor}`,
large: `0 6px 8px ${defaultColor}, 0 10px 20px ${defaultColor}`,
xlarge: `0 9px 12px ${defaultColor}, 0 14px 28px ${defaultColor}`,
};

export const shadows = [
['shadow-small', { 'box-shadow': 'var(--w-shadow-small)' }],
['shadow-medium', { 'box-shadow': 'var(--w-shadow-medium)' }],
['shadow-large', { 'box-shadow': 'var(--w-shadow-large)' }],
['shadow-xlarge', { 'box-shadow': 'var(--w-shadow-xlarge)' }],
[/^shadow-(small|medium|large|xlarge)$/, ([, size]) => ({ 'box-shadow': `var(--w-shadow-${size}, ${boxShadowDefaults[size]})` })],
];
8 changes: 4 additions & 4 deletions test/__snapshots__/shadow.js.snap
View file
Open in desktop
Expand Up @@ -2,8 +2,8 @@

exports[`shadows work 1`] = `
"/* layer: default */
.shadow-small{box-shadow:var(--w-shadow-small);}
.shadow-medium{box-shadow:var(--w-shadow-medium);}
.shadow-large{box-shadow:var(--w-shadow-large);}
.shadow-xlarge{box-shadow:var(--w-shadow-xlarge);}"
.shadow-large{box-shadow:var(--w-shadow-large, 0 6px 8px rgba(0, 0, 0, .2), 0 10px 20px rgba(0, 0, 0, .2));}
.shadow-medium{box-shadow:var(--w-shadow-medium, 0 3px 8px rgba(0, 0, 0, .2), 0 3px 6px rgba(0, 0, 0, .2));}
.shadow-small{box-shadow:var(--w-shadow-small, 0 1px 6px rgba(0, 0, 0, .2), 0 1px 1px rgba(0, 0, 0, .2));}
.shadow-xlarge{box-shadow:var(--w-shadow-xlarge, 0 9px 12px rgba(0, 0, 0, .2), 0 14px 28px rgba(0, 0, 0, .2));}"
`;