Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Refactor a lot of build things for icons #58

Merged
merged 2 commits into from
Nov 16, 2023
Merged

fix: Refactor a lot of build things for icons #58

merged 2 commits into from
Nov 16, 2023

Conversation

imprashast
Copy link
Contributor

@imprashast imprashast commented Nov 13, 2023 •
edited
Loading

Doing a lot of things in this PR:

  1. Rename build files and remove the word eik since they don't build anything EIK related.
  2. Remove Eik publish step from github action.
  3. Don't minify things that go on NPM since it confuses tree-shaking algos.
  4. Try bundling types in a better way for named exported icons.
  5. Generate types for individual icons since it's hard to find imports in IDE without it.

Also fixing everything in this ticket: https://nmp-jira.atlassian.net/browse/WARP-377

@imprashast imprashast requested a review from a team November 13, 2023 15:55
@imprashast imprashast merged commit 5c0efc8 into next Nov 16, 2023
2 checks passed
@imprashast imprashast deleted the icons-fix branch November 16, 2023 13:14
github-actions bot pushed a commit that referenced this pull request Nov 16, 2023
@semantic-release-bot
chore(release): 1.2.1-next.1 [skip ci]
e737941 
## [1.2.1-next.1](v1.2.0...v1.2.1-next.1) (2023-11-16)

### Bug Fixes

* Refactor a lot of build things for icons ([#58](#58)) ([5c0efc8](5c0efc8))
github-actions bot pushed a commit that referenced this pull request Nov 23, 2023
@semantic-release-bot
chore(release): 1.3.0 [skip ci]
3f70d77 
# [1.3.0](v1.2.0...v1.3.0) (2023-11-23)

### Bug Fixes

* Add export to react script which broke exports in index.js ([#61](#61)) ([57288c6](57288c6))
* Refactor a lot of build things for icons ([#58](#58)) ([5c0efc8](5c0efc8))

### Features

* Add new icons ([#59](#59)) ([6cce394](6cce394))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felicia-haggqvist felicia-haggqvist felicia-haggqvist approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@imprashast @felicia-haggqvist