feat: Add new icons #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felicia-haggqvist
approved these changes
Nov 17, 2023
|
@felicia-haggqvist I don't think we need to have both Twitter X and Twitter. |
|
@BalbinaK Ah I just didn't remember what we decided regarding the Twitter icon :) |
|
I saw in the ticket description "Updated Twitter icon" so I understood it as "replace the old one". At least that's why I did so in Fabric (fabric-ds/icons#52) 😄 |
|
Yeah I saw that description in the ticket. "Updated Twitter icon" is a bit vague and easy to interpret in different ways. 😄 |
Twitter icons was already updated to the new logo so there's no need to introduce a new icon.
|
We've clarified with Henrik that we should replace the old icon and keep the old name so it's fixed in 91bb5c1. |
|
Added missing viewbox values. I think the PR is ready to merge but we should maybe wait with a stable release until next week. |
github-actions bot
pushed a commit
that referenced
this pull request
Nov 21, 2023
# [1.3.0-next.1](v1.2.1-next.1...v1.3.0-next.1) (2023-11-21) ### Features * Add new icons ([#59](#59)) ([6cce394](6cce394))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dealing with https://nmp-jira.atlassian.net/browse/WARP-380