fixed #270 - decode_pkcs5 does not remove padding

warp-tech · Apr 22, 2024 · 0915744 · 0915744
1 parent 58d9274
commit 0915744
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/russh-keys/src/format/pkcs5.rs b/russh-keys/src/format/pkcs5.rs
@@ -25,8 +25,7 @@ pub fn decode_pkcs5(
                 #[allow(clippy::unwrap_used)] // AES parameters are static
                 let c = cbc::Decryptor::<Aes128>::new_from_slices(&md5.0, &iv[..]).unwrap();
                 let mut dec = secret.to_vec();
-                c.decrypt_padded_mut::<Pkcs7>(&mut dec)?;
-                dec
+                c.decrypt_padded_mut::<Pkcs7>(&mut dec)?.to_vec()
             }
             Encryption::Aes256Cbc(_) => unimplemented!(),
         };