Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the Handler traits #247

Merged
merged 8 commits into from
Feb 10, 2024
Merged

Conversation

ricott1
Copy link
Contributor

@ricott1 ricott1 commented Feb 7, 2024

Follow up to #191.

  • Remove the owned pattern with tuple return for the Handlers traits in favour of &mut references.

@ricott1
Copy link
Contributor Author

ricott1 commented Feb 8, 2024

I was also thinking about moving run and run_on_socket to the Server trait, I will do that in a separate commit, what do you think?

russh/src/client/mod.rs Outdated Show resolved Hide resolved
russh/src/client/mod.rs Outdated Show resolved Hide resolved
@ricott1 ricott1 requested a review from lowlevl February 8, 2024 16:35
@lowlevl
Copy link
Contributor

lowlevl commented Feb 8, 2024

I guess it looks good to me, but as I said, I'm not the one to decide :)

@Eugeny
Copy link
Member

Eugeny commented Feb 10, 2024

great job @ricott1 and thanks for reviewing @lowlevl !

@Eugeny
Copy link
Member

Eugeny commented Feb 10, 2024

@all-contributors add @ricott1 for code

Copy link
Contributor

@Eugeny

I've put up a pull request to add @ricott1! 🎉

@Eugeny Eugeny merged commit c19c6f4 into warp-tech:main Feb 10, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants