Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation error when using without the flate2 feature #263

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

citorva
Copy link
Contributor

@citorva citorva commented Mar 27, 2024

When compiling without the default features, the compilation of russh fail with message concerning unknown Error type in compression.rs and unknown flate2 crate in lib.rs (when defining the error type)

This PR specify the same Error type as the flate2-featured Compression/Decompression function and disable error cases specific to flate2.

@Eugeny
Copy link
Member

Eugeny commented Mar 27, 2024

Thank you!

@Eugeny
Copy link
Member

Eugeny commented Mar 27, 2024

@all-contributors add @citorva for code

@Eugeny Eugeny merged commit 58d9274 into warp-tech:main Mar 27, 2024
4 checks passed
Copy link
Contributor

@Eugeny

I've put up a pull request to add @citorva! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants