Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show scrollbars on Linux/Windows #99

Closed
warpdesign opened this issue Feb 13, 2020 · 3 comments
Closed

Show scrollbars on Linux/Windows #99

warpdesign opened this issue Feb 13, 2020 · 3 comments
Labels
enhancement New feature or request linux windows
Milestone

Comments

@warpdesign
Copy link
Owner

Current version of React-Explorer uses overlayScrollbars which are hidding big ugly scrollbars on Windows/Linux. Problem scrollbars seem to be hidden and using touchpad to scroll does not seem to make them appear.

Using SimpleBar could be a good idea.

Also, the overlayScrollbars of Chrome was removed in Chrome 78 so will likely be removed from Electron as well.

@warpdesign
Copy link
Owner Author

warpdesign commented Feb 15, 2020

After some experiments it won't be that easy to use SimpleBar (or react-custom-scrollbars) since React-Explorer is using AutoSizer+Table (which itself uses Grid) all from React-Virtualized.

Saw hacks hooking into the onScroll event to position the grid but performance really suffers and it's not easy to implement.

Alternative: using css-only solution overflow: overlay. For example:

body {
  overflow: overlay;
}

 ::-webkit-scrollbar {
  width: 10px;
  height: 10px;
}

::-webkit-scrollbar-thumb {
  background: rgba(90, 90, 90, .3);
  border-radius:5px;
}

::-webkit-scrollbar-track {
  background: rgba(0, 0, 0, 0);
} 

Only drawback is that the scrollbar won't auto hide.

@warpdesign
Copy link
Owner Author

Elements that need to be scrollable:

  • Dialog
  • FileTable
  • Favorites

@warpdesign
Copy link
Owner Author

Fixed in #110

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request linux windows
Projects
None yet
Development

No branches or pull requests

1 participant